Conversation
🦋 Changeset detectedLatest commit: 860d3f2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ascorbic
force-pushed
the
recursive-schema-types
branch
from
b6c075f to
860d3f2
Compare
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
I honestly didn't understand what we're fixing. Can you share some screenshot or something, since we can't create a test?
|
The fix is that previously the recursive type meant that the type-checker gave up and typed This PR gets rid of the recursion. The price is that it no longer attempts to type-check unions of unions, but as previously it wasn't type-checking anything, that's not a loss! |
|
...and now: |
3 participants
Changes
Currently the way that
BaseSchemaWithoutEffectsis defined means that it's infinitely recursive, causing TypeScript to bail and type it asany. This means that there's no proper typechecking on content config schema, and was also making it hard to type live content loaders. This PR should fix that: it splits the composite types out. It no longer uses recursive types for allowed unions, but instead allows unions of non-unions, but also allows unions of any other unions. We don't check those deep unions anymore because wtf calm down stop being mean to TypeScript.Testing
Tested both with the examples, but also the docs site and manually with various combinations.
Docs